-
Notifications
You must be signed in to change notification settings - Fork 33
Add document type icons to the items #21
Conversation
This way it's easier to tell the items apart when they're all collapsed
|
Initial thoughts are:
|
Hide icons by means of prevalue configuration.
|
@mattbrailsford done. I don't know about the prevalue config ... do we really want to add config options for every little thing? But all the same, I added it for now and it works. |
|
I know what you mean about config options, but when it's visual, I kinda like to have the option as not everyone will want them. That said, if we hear that every person turns them on, in the future we can just remove the config option and have them by default. Spacing looks much better (it's the little things) |
|
I think the prevalue should be "Show Icons" rather than "Hide Icons". Happy for it to default to true though, see core examples for how to set default value https://github.com/umbraco/Umbraco-CMS/blob/dev-v7/src/Umbraco.Web/PropertyEditors/ContentPickerPropertyEditor.cs |
|
Aite... I just made it "hide icons" because there is a "hide label" too... trying to get less boolean confuzzlement :) but no problem, I'll look at it. |
|
Done - "hide icons" is now "show icons". Note that this PR now also fixes the default value for "confirm deletes" (which should be a string value, not an integer). |
Add document type icons to the items
|
Thanks @kjac - looks great! |
|
You're welcome :-)
|

This way it's easier to tell the items apart when they're all collapsed.